Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorConnor Shea <connor.james.shea@gmail.com>2018-03-01 01:58:12 +0300
committerConnor Shea <connor.james.shea@gmail.com>2018-03-01 01:58:12 +0300
commit25283e71011490c674c54e64384957a692235e38 (patch)
tree4d9bbed465e5978236a66f9a6fc081e933dcbdbc
parent83b3e9fa40571c7475bc803b15e9b57ad2dc36b8 (diff)
Update inline_javascript.rb to lint uses of the javascript filter as well as script tags.
-rw-r--r--lib/haml_lint/inline_javascript.rb8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb
index ff447513fd1..4f776330e80 100644
--- a/lib/haml_lint/inline_javascript.rb
+++ b/lib/haml_lint/inline_javascript.rb
@@ -6,7 +6,13 @@ unless Rails.env.production?
module HamlLint
class Linter::InlineJavaScript < Linter
include LinterRegistry
-
+
+ def visit_filter(node)
+ return unless node.filter_type == 'javascript'
+
+ record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)')
+ end
+
def visit_tag(node)
return unless node.tag_name == 'script'