diff options
author | Filipa Lacerda <filipa@gitlab.com> | 2018-09-25 18:56:35 +0300 |
---|---|---|
committer | Filipa Lacerda <filipa@gitlab.com> | 2018-09-25 18:56:35 +0300 |
commit | 1d688dab69847be764b159f8cc66b14bcf39edc3 (patch) | |
tree | 7b24390a142fdff6766cc28fd42707882763a81f | |
parent | 30a22622ba656c71219d834faebeea72ac9e35e1 (diff) |
Fix bad resolved conflict
-rw-r--r-- | app/assets/javascripts/jobs/components/sidebar_details_block.vue | 26 |
1 files changed, 7 insertions, 19 deletions
diff --git a/app/assets/javascripts/jobs/components/sidebar_details_block.vue b/app/assets/javascripts/jobs/components/sidebar_details_block.vue index cbad9cdd82a..1f91a2cfbaa 100644 --- a/app/assets/javascripts/jobs/components/sidebar_details_block.vue +++ b/app/assets/javascripts/jobs/components/sidebar_details_block.vue @@ -23,10 +23,6 @@ type: Object, required: true, }, - isLoading: { - type: Boolean, - required: true, - }, runnerHelpUrl: { type: String, required: false, @@ -39,9 +35,6 @@ }, }, computed: { - shouldRenderContent() { - return !this.isLoading && Object.keys(this.job).length > 0; - }, coverage() { return `${this.job.coverage}%`; }, @@ -97,11 +90,12 @@ }, hasStages() { return ( - this.job && - this.job.pipeline && - this.job.pipeline.stages && - this.job.pipeline.stages.length > 0 - ) || false; + (this.job && + this.job.pipeline && + this.job.pipeline.stages && + this.job.pipeline.stages.length > 0) || + false + ); }, commit() { return this.job.pipeline.commit || {}; @@ -271,11 +265,5 @@ :commit="commit" :merge-request="job.merge_request" /> - </template> - <gl-loading-icon - v-if="isLoading" - :size="2" - class="prepend-top-10" - /> - </div> + </aside> </template> |