Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipa Lacerda <filipa@gitlab.com>2019-06-24 12:21:25 +0300
committerFilipa Lacerda <filipa@gitlab.com>2019-06-24 12:21:25 +0300
commit833cb6e9f1506cf920c9bdf61cdb0095899ec778 (patch)
treee8663f745ad6959f4198bc382d6e7350747a7076
parent6e8640a0b88e8803b40d13d4a9e23f376521d0b4 (diff)
parent8c92afc3781aa9a6278f0a739ad6f7113fc4cdcc (diff)
Merge branch 'gt-remove-tooltip-directive-on-project-avatar-image-component' into 'master'
Remove tooltip directive on project avatar image component Closes #51990 See merge request gitlab-org/gitlab-ce!29631
-rw-r--r--app/assets/javascripts/vue_shared/components/project_avatar/image.vue21
-rw-r--r--changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml5
2 files changed, 5 insertions, 21 deletions
diff --git a/app/assets/javascripts/vue_shared/components/project_avatar/image.vue b/app/assets/javascripts/vue_shared/components/project_avatar/image.vue
index e77b9ddc7ba..b9311d65360 100644
--- a/app/assets/javascripts/vue_shared/components/project_avatar/image.vue
+++ b/app/assets/javascripts/vue_shared/components/project_avatar/image.vue
@@ -17,13 +17,9 @@
import defaultAvatarUrl from 'images/no_avatar.png';
import { placeholderImage } from '../../../lazy_loader';
-import tooltip from '../../directives/tooltip';
export default {
name: 'ProjectAvatarImage',
- directives: {
- tooltip,
- },
props: {
lazy: {
type: Boolean,
@@ -50,16 +46,6 @@ export default {
required: false,
default: 20,
},
- tooltipText: {
- type: String,
- required: false,
- default: '',
- },
- tooltipPlacement: {
- type: String,
- required: false,
- default: 'top',
- },
},
computed: {
// API response sends null when gravatar is disabled and
@@ -71,9 +57,6 @@ export default {
resultantSrcAttribute() {
return this.lazy ? placeholderImage : this.sanitizedSource;
},
- tooltipContainer() {
- return this.tooltipText ? 'body' : null;
- },
avatarSizeClass() {
return `s${this.size}`;
},
@@ -83,7 +66,6 @@ export default {
<template>
<img
- v-tooltip
:class="{
lazy: lazy,
[avatarSizeClass]: true,
@@ -94,9 +76,6 @@ export default {
:height="size"
:alt="imgAlt"
:data-src="sanitizedSource"
- :data-container="tooltipContainer"
- :data-placement="tooltipPlacement"
- :title="tooltipText"
class="avatar"
/>
</template>
diff --git a/changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml b/changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml
new file mode 100644
index 00000000000..d9ca20d9d4d
--- /dev/null
+++ b/changelogs/unreleased/gt-remove-tooltip-directive-on-project-avatar-image-component.yml
@@ -0,0 +1,5 @@
+---
+title: Remove tooltip directive on project avatar image component
+merge_request: 29631
+author: George Tsiolis
+type: performance