diff options
| author | Imre Farkas <ifarkas@gitlab.com> | 2019-11-26 11:32:07 +0300 |
|---|---|---|
| committer | Imre Farkas <ifarkas@gitlab.com> | 2019-11-26 12:26:25 +0300 |
| commit | b308c803aa50bc15be049215ab16506608046512 (patch) | |
| tree | 1b86da92e112950faf05150342cbfcd3a88a83dd | |
| parent | 0531a33889145d8bfa05fd8bcdc033aaceb4987d (diff) | |
Spec to ensure `_ids` are cleaned by ImportExport::AttributeCleaner
| -rw-r--r-- | changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml | 5 | ||||
| -rw-r--r-- | spec/lib/gitlab/import_export/attribute_cleaner_spec.rb | 5 |
2 files changed, 9 insertions, 1 deletions
diff --git a/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml b/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml new file mode 100644 index 00000000000..08fc1393f20 --- /dev/null +++ b/changelogs/unreleased/security-exclude_ids_attribute_cleaning.yml @@ -0,0 +1,5 @@ +--- +title: Ensure are cleaned by ImportExport::AttributeCleaner +merge_request: +author: +type: security diff --git a/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb b/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb index c4052415ab0..44192c4639d 100644 --- a/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb +++ b/spec/lib/gitlab/import_export/attribute_cleaner_spec.rb @@ -26,7 +26,10 @@ describe Gitlab::ImportExport::AttributeCleaner do '_html' => '<p>perfectly ordinary html</p>', 'cached_markdown_version' => 12345, 'group_id' => 99, - 'commit_id' => 99 + 'commit_id' => 99, + 'issue_ids' => [1, 2, 3], + 'merge_request_ids' => [1, 2, 3], + 'note_ids' => [1, 2, 3] } end |