Use attr_accessor for reference_type methods

Since it doesn't really matter if "reference_type" is given a Symbol or
a String we might as well just use "attr_accessor".

3 files changed, 6 insertions, 14 deletions

diff --git a/lib/banzai/filter/reference_filter.rb b/lib/banzai/filter/reference_filter.rb
index 9feb86393ee..1954eb380f1 100644
--- a/lib/banzai/filter/reference_filter.rb
+++ b/lib/banzai/filter/reference_filter.rb
@@ -8,12 +8,8 @@ module Banzai
     #   :project (required) - Current project, ignored if reference is cross-project.
     #   :only_path          - Generate path-only links.
     class ReferenceFilter < HTML::Pipeline::Filter
-      def self.reference_type=(type)
-        @reference_type = type.to_sym
-      end
-
-      def self.reference_type
-        @reference_type
+      class << self
+        attr_accessor :reference_type
       end
 
       # Returns a data attribute String to attach to a reference link
diff --git a/lib/banzai/reference_parser/parser.rb b/lib/banzai/reference_parser/parser.rb
index bd2f79f6ddc..de4725c8dfa 100644
--- a/lib/banzai/reference_parser/parser.rb
+++ b/lib/banzai/reference_parser/parser.rb
@@ -31,12 +31,8 @@ module Banzai
     # `nodes_visible_to_user` method so it can ensure users can only see issues
     # they have access to.
     class Parser
-      def self.reference_type=(type)
-        @reference_type = type.to_sym
-      end
-
-      def self.reference_type
-        @reference_type
+      class << self
+        attr_accessor :reference_type
       end
 
       def initialize(project = nil, current_user = nil)
diff --git a/spec/lib/banzai/reference_parser/parser_spec.rb b/spec/lib/banzai/reference_parser/parser_spec.rb
index 393c573bf5d..ca85c7cffc1 100644
--- a/spec/lib/banzai/reference_parser/parser_spec.rb
+++ b/spec/lib/banzai/reference_parser/parser_spec.rb
@@ -6,9 +6,9 @@ describe Banzai::ReferenceParser::Parser, lib: true do
   let(:parser) { described_class.new(project, user) }
 
   describe '.reference_type=' do
-    it 'sets the reference type as a Symbol' do
+    it 'sets the reference type' do
       dummy = Class.new(described_class)
-      dummy.reference_type = 'foo'
+      dummy.reference_type = :foo
 
       expect(dummy.reference_type).to eq(:foo)
     end