diff options
author | Phil Hughes <me@iamphill.com> | 2017-06-22 13:50:29 +0300 |
---|---|---|
committer | kushalpandya <kushal@gitlab.com> | 2017-06-23 14:42:10 +0300 |
commit | 97d60c3d23c00c837dfa9f99a0369f6d0bfbb319 (patch) | |
tree | a245189f0fced6b161a5975786ce6c0f32135eb6 | |
parent | 7a17d76e013ef636037da2422458ee2c48fd0618 (diff) |
Merge branch '33904-edit-issue-warning' into 'master'
don't show "Someone edited the issue" warning when saving issue
Closes #33904
See merge request !12371
-rw-r--r-- | app/assets/javascripts/issue_show/components/app.vue | 6 | ||||
-rw-r--r-- | app/assets/javascripts/issue_show/stores/index.js | 10 |
2 files changed, 6 insertions, 10 deletions
diff --git a/app/assets/javascripts/issue_show/components/app.vue b/app/assets/javascripts/issue_show/components/app.vue index 8473a81bc88..3d5fb7f441c 100644 --- a/app/assets/javascripts/issue_show/components/app.vue +++ b/app/assets/javascripts/issue_show/components/app.vue @@ -204,13 +204,7 @@ export default { method: 'getData', successCallback: (res) => { const data = res.json(); - const shouldUpdate = this.store.stateShouldUpdate(data); - this.store.updateState(data); - - if (this.showForm && (shouldUpdate.title || shouldUpdate.description)) { - this.store.formState.lockedWarningVisible = true; - } }, errorCallback(err) { throw new Error(err); diff --git a/app/assets/javascripts/issue_show/stores/index.js b/app/assets/javascripts/issue_show/stores/index.js index f2b822f3cbb..0c8bd6f1cc3 100644 --- a/app/assets/javascripts/issue_show/stores/index.js +++ b/app/assets/javascripts/issue_show/stores/index.js @@ -12,6 +12,10 @@ export default class Store { } updateState(data) { + if (this.stateShouldUpdate(data)) { + this.formState.lockedWarningVisible = true; + } + this.state.titleHtml = data.title; this.state.titleText = data.title_text; this.state.descriptionHtml = data.description; @@ -23,10 +27,8 @@ export default class Store { } stateShouldUpdate(data) { - return { - title: this.state.titleText !== data.title_text, - description: this.state.descriptionText !== data.description_text, - }; + return this.state.titleText !== data.title_text || + this.state.descriptionText !== data.description_text; } setFormState(state) { |