Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2016-08-16 06:57:28 +0300
committerStan Hu <stanhu@gmail.com>2016-08-16 06:57:28 +0300
commit48b5812a449e5d090d3529e3fbfb679cee7de5da (patch)
treece0e5f2bc473c2e983b37ec66ffe3d1569b47dc5
parent5a4ecb9825f34011e9e021af70a3ff0a696ec3f7 (diff)
Make Capybara finders less susceptible to timing issues
-rw-r--r--spec/features/merge_requests/diff_notes_spec.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/spec/features/merge_requests/diff_notes_spec.rb b/spec/features/merge_requests/diff_notes_spec.rb
index 12e89742b79..4b3de1d8f89 100644
--- a/spec/features/merge_requests/diff_notes_spec.rb
+++ b/spec/features/merge_requests/diff_notes_spec.rb
@@ -129,11 +129,13 @@ feature 'Diff notes', js: true, feature: true do
end
def get_inline_line_components(line_holder)
- { content: line_holder.first('.line_content'), num: line_holder.first('.diff-line-num') }
+ { content: line_holder.find('.line_content', match: :first), num: line_holder.find('.diff-line-num', match: :first) }
end
def get_parallel_line_components(line_holder, diff_side = nil)
side_index = diff_side == 'left' ? 0 : 1
+ find('.line_content', match: :first)
+ find('.diff-line-num', match: :first)
{ content: line_holder.all('.line_content')[side_index], num: line_holder.all('.diff-line-num')[side_index] }
end