diff options
| author | Marcia Ramos <virtua.creative@gmail.com> | 2018-12-12 00:49:03 +0300 |
|---|---|---|
| committer | Marcia Ramos <virtua.creative@gmail.com> | 2018-12-12 00:49:03 +0300 |
| commit | 0ad135629f181518b230a1bed4111b2999f7d333 (patch) | |
| tree | 2347cebd48842d7bf5dc096950fb90d0b8e7d8ff | |
| parent | 91c64c045a9632295ca06f665c17cdec7743458d (diff) | |
| parent | ceb7631ca534c19f1782bdfe713c6b8d89ad5f93 (diff) | |
Merge branch 'mk/fix-links-to-sections-that-were-moved' into 'master'
Docs: Fix links to sections that were moved
See merge request gitlab-org/gitlab-ce!23750
| -rw-r--r-- | doc/development/code_review.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 7788d155154..25ea2211b64 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -10,7 +10,7 @@ code is effective, understandable, maintainable, and secure. ## Getting your merge request reviewed, approved, and merged You are strongly encouraged to get your code **reviewed** by a -[reviewer](https://about.gitlab.com/handbook/engineering/#reviewer) as soon as +[reviewer](https://about.gitlab.com/handbook/engineering/workflow/code-review/#reviewer) as soon as there is any code to review, to get a second opinion on the chosen solution and implementation, and an extra pair of eyes looking for bugs, logic problems, or uncovered edge cases. The reviewer can be from a different team, but it is @@ -24,7 +24,7 @@ If you need assistance with security scans or comments, feel free to include the Security Team (`@gitlab-com/gl-security`) in the review. Depending on the areas your merge request touches, it must be **approved** by one -or more [maintainers](https://about.gitlab.com/handbook/engineering/#maintainer): +or more [maintainers](https://about.gitlab.com/handbook/engineering/workflow/code-review/#maintainer): For approvals, we use the approval functionality found in the merge request widget. Reviewers can add their approval by [approving additionally](https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#adding-or-removing-an-approval). |