diff options
| author | Sean McGivern <sean@gitlab.com> | 2019-08-05 10:52:08 +0300 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2019-08-05 10:52:08 +0300 |
| commit | c1ad664588bf185265c75ff437484a758cee72d1 (patch) | |
| tree | 2cb2fcf8f8e5b44e8212509688cdc03841093b61 | |
| parent | d594217e9f9033f4b7d37dbcd4dfe376f1994fca (diff) | |
| parent | 788ff54816769117279e64dde7b9578c62b03ecf (diff) | |
Merge branch 'bvl-fix-sentry-error-grouping' into 'master'
Group `parent not preloaded` errors in sentry
See merge request gitlab-org/gitlab-ce!31424
| -rw-r--r-- | app/models/concerns/group_descendant.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/models/concerns/group_descendant.rb b/app/models/concerns/group_descendant.rb index cfffd845e43..ed14b73ac1b 100644 --- a/app/models/concerns/group_descendant.rb +++ b/app/models/concerns/group_descendant.rb @@ -42,7 +42,7 @@ module GroupDescendant parent = child.parent exception = ArgumentError.new <<~MSG - parent: [GroupDescendant: #{parent.inspect}] was not preloaded for [#{child.inspect}]") + Parent was not preloaded for child when rendering group hierarchy. This error is not user facing, but causes a +1 query. MSG extras = { @@ -50,7 +50,7 @@ module GroupDescendant child: child.inspect, preloaded: preloaded.map(&:full_path) } - issue_url = 'https://gitlab.com/gitlab-org/gitlab-ce/issues/40785' + issue_url = 'https://gitlab.com/gitlab-org/gitlab-ce/issues/49404' Gitlab::Sentry.track_exception(exception, issue_url: issue_url, extra: extras) end |