diff options
author | Robert Speicher <rspeicher@gmail.com> | 2017-03-21 02:17:14 +0300 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2017-03-21 02:17:14 +0300 |
commit | 9bf9e6eb38b955791abce475dbaec1001d6c39c0 (patch) | |
tree | ded2d40410270b25fca5e0c7a5692611031390c7 | |
parent | b075d38c9b98d4b39441bd29d2c36be4637b6f72 (diff) |
Handle Route#name being nil after an update
It was possible for the `routes.name` field to be `NULL`, causing
`name_was` to be `nil` after a rename, resulting a bad first argument to
`sub` when attempting to rename descendants. This change adds a
condition to make sure `name_was` is present before attempting the
descendant update.
-rw-r--r-- | app/models/route.rb | 2 | ||||
-rw-r--r-- | spec/models/route_spec.rb | 12 |
2 files changed, 11 insertions, 3 deletions
diff --git a/app/models/route.rb b/app/models/route.rb index 73574a6206b..41e6eb7cb73 100644 --- a/app/models/route.rb +++ b/app/models/route.rb @@ -21,7 +21,7 @@ class Route < ActiveRecord::Base attributes[:path] = route.path.sub(path_was, path) end - if name_changed? && route.name.present? + if name_changed? && name_was.present? && route.name.present? attributes[:name] = route.name.sub(name_was, name) end diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb index 0b222022e62..bc8ae4ae5a8 100644 --- a/spec/models/route_spec.rb +++ b/spec/models/route_spec.rb @@ -43,14 +43,22 @@ describe Route, models: true do end context 'name update' do - before { route.update_attributes(name: 'bar') } - it "updates children routes with new path" do + route.update_attributes(name: 'bar') + expect(described_class.exists?(name: 'bar')).to be_truthy expect(described_class.exists?(name: 'bar / test')).to be_truthy expect(described_class.exists?(name: 'bar / test / foo')).to be_truthy expect(described_class.exists?(name: 'gitlab-org')).to be_truthy end + + it 'handles a rename from nil' do + # Note: using `update_columns` to skip all validation and callbacks + route.update_columns(name: nil) + + expect { route.update_attributes(name: 'bar') } + .to change { route.name }.from(nil).to('bar') + end end end end |