diff options
author | Michael Kozono <mkozono@gmail.com> | 2017-11-15 09:18:05 +0300 |
---|---|---|
committer | Michael Kozono <mkozono@gmail.com> | 2017-11-17 03:51:39 +0300 |
commit | 65165016440dbcbbaca4cda0d4973ffc7961c56e (patch) | |
tree | 9e82caa775b6f5101e89cae9be2e77b8c0474ed4 | |
parent | fb9daaf05cc2f59b989c962a178ff72ea081be92 (diff) |
Fix uploads.path length for long filenames
This will prevent our other migration for adding old files to the uploads table from breaking.
-rw-r--r-- | db/migrate/20171103000000_set_uploads_path_size_for_mysql.rb | 25 | ||||
-rw-r--r-- | db/schema.rb | 2 |
2 files changed, 26 insertions, 1 deletions
diff --git a/db/migrate/20171103000000_set_uploads_path_size_for_mysql.rb b/db/migrate/20171103000000_set_uploads_path_size_for_mysql.rb new file mode 100644 index 00000000000..1fbe505f804 --- /dev/null +++ b/db/migrate/20171103000000_set_uploads_path_size_for_mysql.rb @@ -0,0 +1,25 @@ +# See http://doc.gitlab.com/ce/development/migration_style_guide.html +# for more information on how to write migrations for GitLab. + +class SetUploadsPathSizeForMysql < ActiveRecord::Migration + include Gitlab::Database::MigrationHelpers + + # Set this constant to true if this migration requires downtime. + DOWNTIME = false + + def up + # We need at least 297 at the moment. For more detail on that number, see: + # https://gitlab.com/gitlab-org/gitlab-ce/issues/40168#what-is-the-expected-correct-behavior + # + # Rails + PostgreSQL `string` is equivalent to a `text` field, but + # Rails + MySQL `string` is `varchar(255)` by default. Also, note that we + # have an upper limit because with a unique index, MySQL has a max key + # length of 3072 bytes which seems to correspond to `varchar(1024)`. + change_column :uploads, :path, :string, limit: 511 + end + + def down + # It was unspecified, which is varchar(255) by default in Rails for MySQL. + change_column :uploads, :path, :string + end +end diff --git a/db/schema.rb b/db/schema.rb index 37e08d453c8..a774dd7bb33 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -1707,7 +1707,7 @@ ActiveRecord::Schema.define(version: 20171106180641) do create_table "uploads", force: :cascade do |t| t.integer "size", limit: 8, null: false - t.string "path", null: false + t.string "path", limit: 511, null: false t.string "checksum", limit: 64 t.integer "model_id" t.string "model_type" |