Merge branch 'note-action-icons' into 'master'

Always show note action icons.

As discussed in #639.

The delete icon becomes red on hover, the edit one becomes slightly darker.

The "Link here" icon has been removed, and the link to the specific comment can now be found by clicking the post date ("3 months ago"), which is most other sites do it as well.

![Screen_Shot_2015-05-14_at_12.18.50](https://gitlab.com/gitlab-org/gitlab-ce/uploads/a204fa3a042659fa53fcb70d7143c8d1/Screen_Shot_2015-05-14_at_12.18.50.png)

See merge request !652

3 files changed, 29 insertions, 29 deletions

diff --git a/app/assets/stylesheets/pages/notes.scss b/app/assets/stylesheets/pages/notes.scss
index 61b907e39be..e943be67dbf 100644
--- a/app/assets/stylesheets/pages/notes.scss
+++ b/app/assets/stylesheets/pages/notes.scss
@@ -33,7 +33,16 @@ ul.notes {
       &:before {
         content: "\00b7";
       }
+
       font-size: 13px;
+
+      a {
+        @extend .cgray;        
+
+        &:hover {
+          text-decoration: underline;
+        }
+      }
     }
     .author {
       color: #333;
@@ -47,7 +56,7 @@ ul.notes {
 
     .note-role {
       float: right;
-      margin-top: 2px;
+      margin-top: 1px;
       border: 1px solid #bbb;
       background-color: transparent;
       color: #999;
@@ -142,31 +151,23 @@ ul.notes {
 
 .discussion,
 .note {
-  &.note:hover {
-    .note-actions { display: block; }
-    .note-actions + .note-role { display: none; }
-  }
-  .discussion-header:hover {
-    .discussion-actions { display: block; }
-  }
-
   .discussion-actions,
   .note-actions {
-    display: none;
     float: right;
-
-    i.fa {
-      font-size: 16px;
-      line-height: 16px;
-      vertical-align: middle;
-    }
+    margin-left: 10px;
 
     a {
       margin-left: 5px;
 
-      @extend .cgray;
+      color: #999;
+
+      i.fa {
+        font-size: 16px;
+        line-height: 16px;
+      }
 
       &:hover {
+        @extend .cgray;
         &.danger { @extend .cred; }
       }
     }
diff --git a/app/views/projects/notes/_note.html.haml b/app/views/projects/notes/_note.html.haml
index 2f3c407d6e9..0a77f200f56 100644
--- a/app/views/projects/notes/_note.html.haml
+++ b/app/views/projects/notes/_note.html.haml
@@ -8,19 +8,13 @@
           = image_tag avatar_icon(note.author_email), class: 'avatar s40', alt: ''
     .timeline-content
       .note-header
-        .note-actions
-          = link_to "##{dom_id(note)}", name: dom_id(note), title: "Link here" do
-            = icon('link fw')
-            Link here
-
-          - if note_editable?(note)
+        - if note_editable?(note)
+          .note-actions
             = link_to '#', title: 'Edit comment', class: 'js-note-edit' do
-              = icon('pencil-square-o fw')
-              Edit
+              = icon('pencil-square-o')
 
-            = link_to namespace_project_note_path(note.project.namespace, note.project, note), title: 'Remove comment', method: :delete, data: { confirm: 'Are you sure you want to remove this comment?' }, remote: true, class: 'danger js-note-delete' do
-              = icon('trash-o fw', class: 'cred')
-              Remove
+            = link_to namespace_project_note_path(note.project.namespace, note.project, note), title: 'Remove comment', method: :delete, data: { confirm: 'Are you sure you want to remove this comment?' }, remote: true, class: 'js-note-delete danger' do
+              = icon('trash-o')
 
         - unless note.system
           - member = note.project.team.find_member(note.author.id)
@@ -33,10 +27,13 @@
             = image_tag avatar_icon(note.author_email), class: 'avatar s16', alt: ''
 
         = link_to_member(note.project, note.author, avatar: false)
+
         %span.author-username
           = '@' + note.author.username
+
         %span.note-last-update
-          = note_timestamp(note)
+          = link_to "##{dom_id(note)}", name: dom_id(note), title: "Link here" do
+            = note_timestamp(note)
 
         - if note.superceded?(@notes)
           - if note.upvote?
diff --git a/app/views/projects/notes/discussions/_active.html.haml b/app/views/projects/notes/discussions/_active.html.haml
index 7c6f7243173..e7a3854701c 100644
--- a/app/views/projects/notes/discussions/_active.html.haml
+++ b/app/views/projects/notes/discussions/_active.html.haml
@@ -14,7 +14,9 @@
       - last_note = discussion_notes.last
       last updated by
       = link_to_member(@project, last_note.author, avatar: false)
+
       %span.discussion-last-update
         #{time_ago_with_tooltip(last_note.updated_at, 'bottom', 'discussion_updated_ago')}
+        
   .discussion-body.js-toggle-content
     = render "projects/notes/discussions/diff", discussion_notes: discussion_notes, note: note