diff options
| author | Kushal Pandya <kushal@gitlab.com> | 2018-05-02 12:53:30 +0300 |
|---|---|---|
| committer | Kushal Pandya <kushal@gitlab.com> | 2018-05-02 12:53:30 +0300 |
| commit | de3194bf897540aae2187abf1ce56667f2889292 (patch) | |
| tree | 39239b4c53f609a3653a8b683de5d688da144cbe | |
| parent | c22a3fa0c5cdc175f2b8232b9704079d27c619d0 (diff) | |
Emit `toggleSubscription` event on component instead of eventHub
| -rw-r--r-- | app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue | 3 | ||||
| -rw-r--r-- | spec/javascripts/sidebar/subscriptions_spec.js | 8 |
2 files changed, 9 insertions, 2 deletions
diff --git a/app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue b/app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue index d69d100a26c..486aff8a938 100644 --- a/app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue +++ b/app/assets/javascripts/sidebar/components/subscriptions/subscriptions.vue @@ -3,7 +3,6 @@ import icon from '~/vue_shared/components/icon.vue'; import toggleButton from '~/vue_shared/components/toggle_button.vue'; import tooltip from '~/vue_shared/directives/tooltip'; - import eventHub from '../../event_hub'; const ICON_ON = 'notifications'; const ICON_OFF = 'notifications-off'; @@ -48,7 +47,7 @@ }, methods: { toggleSubscription() { - eventHub.$emit('toggleSubscription', this.id); + this.$emit('toggleSubscription', this.id); }, }, }; diff --git a/spec/javascripts/sidebar/subscriptions_spec.js b/spec/javascripts/sidebar/subscriptions_spec.js index aee8f0acbb9..11ff126dfb5 100644 --- a/spec/javascripts/sidebar/subscriptions_spec.js +++ b/spec/javascripts/sidebar/subscriptions_spec.js @@ -39,4 +39,12 @@ describe('Subscriptions', function () { expect(vm.$refs.toggleButton.$el.querySelector('.project-feature-toggle')).toHaveClass('is-checked'); }); + + it('toggleSubscription method emits `toggleSubscription` event on component', () => { + vm = mountComponent(Subscriptions, { subscribed: true }); + spyOn(vm, '$emit'); + + vm.toggleSubscription(); + expect(vm.$emit).toHaveBeenCalledWith('toggleSubscription', jasmine.any(Object)); + }); }); |