Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2019-04-08 14:16:26 +0300
committerRémy Coutable <remy@rymai.me>2019-04-08 14:16:26 +0300
commiteb377b85def270e44ea476fc37c045c9a3de6473 (patch)
treed0fc9ce26c03d3fbcdc33285647886fcaf8571a7
parent942ce36a72b460f8cac2091008869d845fd365e3 (diff)
parent84ec11131dee8a0137bc8d8b6ab9f6a1e452ed11 (diff)
Merge branch 'docs-update-rspec-set-usage' into 'master'
Add doc when rspec-set won't work See merge request gitlab-org/gitlab-ce!27050
-rw-r--r--doc/development/testing_guide/best_practices.md6
1 files changed, 4 insertions, 2 deletions
diff --git a/doc/development/testing_guide/best_practices.md b/doc/development/testing_guide/best_practices.md
index 7262c04d746..e41148360f2 100644
--- a/doc/development/testing_guide/best_practices.md
+++ b/doc/development/testing_guide/best_practices.md
@@ -216,8 +216,10 @@ project, one project will do for the entire file. This can be achieved by using
reloads or recreates the model, _only_ if needed. That is, when you changed
properties or destroyed the object.
-There is one gotcha; you can't reference a model defined in a `let` block in a
-`set` block.
+Note that you can't reference a model defined in a `let` block in a `set` block.
+
+Also, `set` is not supported in `:js` specs since those don't use transactions
+to clean up database state after each example.
### Time-sensitive tests