diff options
| author | Douwe Maan <douwe@gitlab.com> | 2019-02-25 14:29:51 +0300 |
|---|---|---|
| committer | Douwe Maan <douwe@gitlab.com> | 2019-02-25 14:29:51 +0300 |
| commit | a15a0f3a2a8c65b96c74d2e9612495a4badaea8f (patch) | |
| tree | 6dc4d083b5c6e59b96de1bab5bcc325f75418a9a | |
| parent | 8cb236908f03cba6f6a1ad5660ce8fbdfa32a50d (diff) | |
| parent | cbeab67a270d550b9d925089af53e9cf6ac3d48a (diff) | |
Merge branch 'docs-update-reviewers-guidelines' into 'master'
Docs: update code review guidelines
Closes #57305
See merge request gitlab-org/gitlab-ce!25460
| -rw-r--r-- | doc/development/code_review.md | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 1b591c7c322..f115045dbb7 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -203,7 +203,10 @@ first time. - Extract unrelated changes and refactorings into future merge requests/issues. - Seek to understand the reviewer's perspective. - Try to respond to every comment. -- Let the reviewer select the "Resolve discussion" buttons. +- The merge request author resolves only the discussions they have fully + addressed. If there's an open reply, an open discussion, a suggestion, + a question, or anything else, the discussion should be left to be resolved + by the reviewer. - Push commits based on earlier rounds of feedback as isolated commits to the branch. Do not squash until the branch is ready to merge. Reviewers should be able to read individual updates based on their earlier feedback. |