diff options
author | Lin Jen-Shin <godfat@godfat.org> | 2018-07-27 12:48:20 +0300 |
---|---|---|
committer | Lin Jen-Shin <godfat@godfat.org> | 2018-07-27 12:48:20 +0300 |
commit | 8e9c787794b19759c17e83f13e770c0ff40fd8ca (patch) | |
tree | 11e2b2a1a45d59f8d69ed0dd438c8783f6fc8223 | |
parent | de1b64e83d66652e21e8b2ccf562e547d72458b0 (diff) |
tooltip_message is frozen so dup it before sanitizing
It's sad that sanitizing is updating the string directly.
-rw-r--r-- | app/views/projects/jobs/_sidebar.html.haml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/views/projects/jobs/_sidebar.html.haml b/app/views/projects/jobs/_sidebar.html.haml index 64c441492bc..759efd4e9d4 100644 --- a/app/views/projects/jobs/_sidebar.html.haml +++ b/app/views/projects/jobs/_sidebar.html.haml @@ -86,7 +86,7 @@ - HasStatus::ORDERED_STATUSES.each do |build_status| - builds.select{|build| build.status == build_status}.each do |build| .build-job{ class: sidebar_build_class(build, @build), data: { stage: build.stage } } - - tooltip = sanitize(build.tooltip_message) + - tooltip = sanitize(build.tooltip_message.dup) = link_to(project_job_path(@project, build), data: { toggle: 'tooltip', html: 'true', title: tooltip, container: 'body' }) do = sprite_icon('arrow-right', size:16, css_class: 'icon-arrow-right') %span{ class: "ci-status-icon-#{build.status}" } |