diff options
author | Sanad Liaquat <sliaquat@gitlab.com> | 2019-04-05 15:08:08 +0300 |
---|---|---|
committer | Sanad Liaquat <sliaquat@gitlab.com> | 2019-04-05 15:08:08 +0300 |
commit | 7a48a06cf3b454021aa466464686fee8c82d6862 (patch) | |
tree | d9a4ea5752ea74fc8651e903ba7ac04a8874a82a | |
parent | 3962b00b4bdea67107b9f43e1c44e9bacb98560d (diff) | |
parent | fd8f0c5c752c3140a9326632fe26da2fd15b4301 (diff) |
Merge branch 'mc/fix/ci-variable-qa' into 'master'
Remove spaces from variable name in CI variable QA test
Closes gitlab-org/quality/nightly#91
See merge request gitlab-org/gitlab-ce!27042
-rw-r--r-- | qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb b/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb index 7aaafde6afa..33f342edb08 100644 --- a/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb +++ b/qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_ci_variable_spec.rb @@ -1,8 +1,7 @@ # frozen_string_literal: true module QA - # Failure issue: https://gitlab.com/gitlab-org/quality/nightly/issues/91 - context 'Verify', :quarantine do + context 'Verify' do describe 'CI variable support' do it 'user adds a CI variable' do Runtime::Browser.visit(:gitlab, Page::Main::Login) @@ -10,17 +9,17 @@ module QA Resource::CiVariable.fabricate! do |resource| resource.key = 'VARIABLE_KEY' - resource.value = 'some CI variable' + resource.value = 'some_CI_variable' end Page::Project::Settings::CICD.perform do |settings| settings.expand_ci_variables do |page| expect(page).to have_field(with: 'VARIABLE_KEY') - expect(page).not_to have_field(with: 'some CI variable') + expect(page).not_to have_field(with: 'some_CI_variable') page.reveal_variables - expect(page).to have_field(with: 'some CI variable') + expect(page).to have_field(with: 'some_CI_variable') end end end |