diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2016-05-26 17:46:54 +0300 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2016-05-26 17:46:54 +0300 |
| commit | 24b24aff754e3c7fd9ba8306fc3a452338872276 (patch) | |
| tree | d6e5e0b4e0debe90fbe51c4b311c5b6357cb330f | |
| parent | 44cc765a8c42a38ebfc3caa16d4a19f56b850aff (diff) | |
| parent | d7bd7a3e7ef2e64f50d5404fe3d90f0c1ff57705 (diff) | |
Merge branch 'discussion-outdated-form' into 'master'
Fixed JS error when trying to remove discussion form
## What does this MR do?
Fixes a JS error which was caused by an ID of the form not matching what was returned by the JSON. Instead of checking that, it gets the current form from the ajax success event.
This would only happen on outdated discussions because the ID of the discussion form ends with `-false` because it isn't active. However, the note is added to an active discussion so the ID returned actually ends in `-true` & therefore the JS couldn't find the correct form.
## What are the relevant issue numbers?
Closes #17778
See merge request !4303
| -rw-r--r-- | app/assets/javascripts/notes.js.coffee | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/app/assets/javascripts/notes.js.coffee b/app/assets/javascripts/notes.js.coffee index 6d9d6528f45..8131d923677 100644 --- a/app/assets/javascripts/notes.js.coffee +++ b/app/assets/javascripts/notes.js.coffee @@ -329,7 +329,7 @@ class @Notes @renderDiscussionNote(note) # cleanup after successfully creating a diff/discussion note - @removeDiscussionNoteForm($("#new-discussion-note-form-#{note.discussion_id}")) + @removeDiscussionNoteForm($(xhr.target)) ### Called in response to the edit note form being submitted |