diff options
| author | Joe Marty <jmarty@iexposure.com> | 2017-11-07 01:12:40 +0300 |
|---|---|---|
| committer | Joe Marty <jmarty@iexposure.com> | 2017-11-07 01:19:15 +0300 |
| commit | dfeb60daa607dd96be689cfd3b2f929138efacdf (patch) | |
| tree | 7f767b472e9e6e5eb6f1b8e09d09728eba71838d | |
| parent | 21d8ec1537c0a6d756ea86d001f30f2d62a52247 (diff) | |
Change Sign Out route from a DELETE to a GET
Closes #39708
| -rw-r--r-- | app/views/layouts/header/_default.html.haml | 2 | ||||
| -rw-r--r-- | changelogs/unreleased/feature-change-signout-route.yml | 5 | ||||
| -rw-r--r-- | config/initializers/devise.rb | 2 |
3 files changed, 7 insertions, 2 deletions
diff --git a/app/views/layouts/header/_default.html.haml b/app/views/layouts/header/_default.html.haml index 5ff6ac5fc00..1eca412aff9 100644 --- a/app/views/layouts/header/_default.html.haml +++ b/app/views/layouts/header/_default.html.haml @@ -61,7 +61,7 @@ = link_to "Help", help_path %li.divider %li - = link_to "Sign out", destroy_user_session_path, method: :delete, class: "sign-out-link" + = link_to "Sign out", destroy_user_session_path, class: "sign-out-link" - if session[:impersonator_id] %li.impersonation = link_to admin_impersonation_path, class: 'impersonation-btn', method: :delete, title: "Stop impersonation", aria: { label: 'Stop impersonation' }, data: { toggle: 'tooltip', placement: 'bottom', container: 'body' } do diff --git a/changelogs/unreleased/feature-change-signout-route.yml b/changelogs/unreleased/feature-change-signout-route.yml new file mode 100644 index 00000000000..bccb85b3eaf --- /dev/null +++ b/changelogs/unreleased/feature-change-signout-route.yml @@ -0,0 +1,5 @@ +--- +title: Change 'Sign Out' route from a DELETE to a GET +merge_request: 39708 +author: Joe Marty +type: changed diff --git a/config/initializers/devise.rb b/config/initializers/devise.rb index c6ec0aeda7b..958859be6cf 100644 --- a/config/initializers/devise.rb +++ b/config/initializers/devise.rb @@ -195,7 +195,7 @@ Devise.setup do |config| config.navigational_formats = [:"*/*", "*/*", :html, :zip] # The default HTTP method used to sign out a resource. Default is :delete. - config.sign_out_via = :delete + config.sign_out_via = :get # ==> OmniAuth # To configure a new OmniAuth provider copy and edit omniauth.rb.sample |