diff options
| author | Fatih Acet <acetfatih@gmail.com> | 2016-12-08 22:05:39 +0300 |
|---|---|---|
| committer | Alejandro RodrÃguez <alejorro70@gmail.com> | 2016-12-14 16:31:01 +0300 |
| commit | 512520f01f67b17f5623f0175b0b25d86ef3942a (patch) | |
| tree | ae011c459d09ce9a92657cc99a5b9e18034743e2 | |
| parent | bc26b06e57dab89f2ec2e0d4600367587d31b98b (diff) | |
Merge branch 'timeago-perf-fix' into 'master'
Fixed timeago re-rendering every element
## What does this MR do?
Fixes an issue when new notes are added timeago will be initialised for every timeago element on the page again and therefore adding more timeouts.
See merge request !7969
| -rw-r--r-- | app/assets/javascripts/lib/utils/datetime_utility.js | 4 | ||||
| -rw-r--r-- | changelogs/unreleased/timeago-perf-fix.yml | 4 |
2 files changed, 7 insertions, 1 deletions
diff --git a/app/assets/javascripts/lib/utils/datetime_utility.js b/app/assets/javascripts/lib/utils/datetime_utility.js index 963d2851e5f..e8e502694d6 100644 --- a/app/assets/javascripts/lib/utils/datetime_utility.js +++ b/app/assets/javascripts/lib/utils/datetime_utility.js @@ -29,7 +29,7 @@ setTimeago = true; } - $timeagoEls.each(function() { + $timeagoEls.filter(':not([data-timeago-rendered])').each(function() { var $el = $(this); $el.attr('title', gl.utils.formatDate($el.attr('datetime'))); @@ -39,6 +39,8 @@ template: '<div class="tooltip local-timeago" role="tooltip"><div class="tooltip-arrow"></div><div class="tooltip-inner"></div></div>' }); } + + $el.attr('data-timeago-rendered', true); gl.utils.renderTimeago($el); }); }; diff --git a/changelogs/unreleased/timeago-perf-fix.yml b/changelogs/unreleased/timeago-perf-fix.yml new file mode 100644 index 00000000000..265e7db29a9 --- /dev/null +++ b/changelogs/unreleased/timeago-perf-fix.yml @@ -0,0 +1,4 @@ +--- +title: Fixed timeago re-rendering every timeago +merge_request: +author: |