diff options
author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-15 02:41:08 +0300 |
---|---|---|
committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-15 02:41:08 +0300 |
commit | 602cac526d55d10ef05558c296ce7f27205801cc (patch) | |
tree | 2e4b4d29176a98687397eed7d7a2b4373b34c26a /CHANGELOG | |
parent | 2ebc63dd3ce08ff35bf89d39e1906ce1cf828b3a (diff) | |
parent | e88aa25f42c394785d4c176046f10c815250c8b1 (diff) |
Merge branch '23319-enable-trailingsemicolon-on-scss-lint' into 'master'
Enforce TrailingSemicolon and EmptyLineBetweenBlocks in scss-lint
## What does this MR do?
Enforces two new scss-lint rules
1. TrailingSemicolon
2. EmptyLineBetweenBlocks
## Are there points in the code the reviewer needs to double check?
Make sure I didn't break anything :grin:
## Why was this MR needed?
Improve our SCSS, Lessen the burden of catching these during the review process
## Screenshots (if relevant)
NOne
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #23319
See merge request !6903
Diffstat (limited to 'CHANGELOG')
-rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index 3d6347c5395..194ee18b74c 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -5,6 +5,7 @@ v 8.13.0 (unreleased) - Respond with 404 Not Found for non-existent tags (Linus Thiel) - Truncate long labels with ellipsis in labels page - Improve tabbing usability for sign in page (ClemMakesApps) + - Enforce TrailingSemicolon and EmptyLineBetweenBlocks in scss-lint - Adding members no longer silently fails when there is extra whitespace - Update runner version only when updating contacted_at - Add link from system note to compare with previous version |