diff options
author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-09-01 20:49:25 +0300 |
---|---|---|
committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-09-01 20:49:25 +0300 |
commit | bc13cd7a9bca2c21d974170f24653934b1bded2d (patch) | |
tree | 9e070b6b581c382bd7d8ff711322a17e4bc073b3 /CHANGELOG | |
parent | 9e2feaa55618f5676ba50428041cda6cc7a32783 (diff) | |
parent | cf1174c673ce4244236b64f25e34f1a609552ede (diff) |
Merge branch '21506-fix-title-dropdown-chevron' into 'master'
Resolve "Inconsistency: Repo Title "down caret" cropped on smaller viewports"
## What does this MR do?
Fixes an issue where the dropdown chevron for a project list was not visible on smaller viewports.
This MR also changes the dropdown trigger into a `button` element for better accessibility (it can now be tabbed to like any link).
## Are there points in the code the reviewer needs to double check?
None that I can think of.
## Why was this MR needed?
Better accessibility and support for smaller viewports.
## Screenshots (if relevant)
Dropdown toggle now targetable by pressing tab to select.
![Screen_Shot_2016-08-31_at_9.12.15_PM](/uploads/8b2038a8ae259efd32da2e94a309ce88/Screen_Shot_2016-08-31_at_9.12.15_PM.png)
Chevron no longer hidden when project title length triggers `overflow: ellipsis`.
![Screen_Shot_2016-08-31_at_9.13.38_PM](/uploads/382e76c06e54bc307106a84ec21ab892/Screen_Shot_2016-08-31_at_9.13.38_PM.png)
## Does this MR meet the acceptance criteria?
- [x] CHANGELOG entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #21506
See merge request !6140
Diffstat (limited to 'CHANGELOG')
-rw-r--r-- | CHANGELOG | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG b/CHANGELOG index a18311fabdc..67471b5f8ff 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -34,6 +34,7 @@ v 8.12.0 (unreleased) - Use JavaScript tooltips for mentions !5301 (winniehell) - Fix markdown help references (ClemMakesApps) - Add last commit time to repo view (ClemMakesApps) + - Fix accessibility and visibility of project list dropdown button !6140 - Added project specific enable/disable setting for LFS !5997 - Don't expose a user's token in the `/api/v3/user` API (!6047) - Remove redundant js-timeago-pending from user activity log (ClemMakesApps) |