diff options
author | Phil Hughes <me@iamphill.com> | 2017-03-09 15:32:43 +0300 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2017-03-09 15:32:43 +0300 |
commit | 7eabb7a9641481d89ccb52b421dcbd8cd63c3bb6 (patch) | |
tree | 2618dea650afc6bb1c238efdb8dffc64b1f84f15 /app/assets/javascripts/boards/models/list.js | |
parent | 236d6595edd2393f4ba4faadd39529fcabe48aec (diff) |
Use reduce instead of a forEach
Changed an isArray check to use -1
Added comment to boards search manager to explain behaviour
Diffstat (limited to 'app/assets/javascripts/boards/models/list.js')
-rw-r--r-- | app/assets/javascripts/boards/models/list.js | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/app/assets/javascripts/boards/models/list.js b/app/assets/javascripts/boards/models/list.js index ad968d2120f..3251ca76b26 100644 --- a/app/assets/javascripts/boards/models/list.js +++ b/app/assets/javascripts/boards/models/list.js @@ -64,16 +64,14 @@ class List { } getIssues (emptyIssues = true) { - const data = { page: this.page }; - gl.issueBoards.BoardsStore.filter.path.split('&').forEach((filterParam) => { - if (filterParam === '') return; + const data = gl.issueBoards.BoardsStore.filter.path.split('&').reduce((data, filterParam) => { + if (filterParam === '') return data; const paramSplit = filterParam.split('='); const paramKeyNormalized = paramSplit[0].replace('[]', ''); const isArray = paramSplit[0].indexOf('[]'); - let value = decodeURIComponent(paramSplit[1]); - value = value.replace(/\+/g, ' '); + const value = decodeURIComponent(paramSplit[1]).replace(/\+/g, ' '); - if (isArray >= 0) { + if (isArray !== -1) { if (!data[paramKeyNormalized]) { data[paramKeyNormalized] = []; } @@ -82,7 +80,9 @@ class List { } else { data[paramKeyNormalized] = value; } - }); + + return data; + }, { page: this.page }); if (this.label && data.label_name) { data.label_name = data.label_name.filter(label => label !== this.label.title); |