diff options
| author | Bryce Johnson <bryce@gitlab.com> | 2017-06-12 21:43:21 +0300 |
|---|---|---|
| committer | Bryce Johnson <bryce@gitlab.com> | 2017-06-29 19:50:45 +0300 |
| commit | 81e9c2842574b10d694a8e29665c77fde7fd6ae5 (patch) | |
| tree | c7fad475df58553505885b9e2de9b9543bc6d3f3 /app/assets/javascripts/diff_notes | |
| parent | 066a6c8ba8900f0883ee788d901d300850b1ae61 (diff) | |
Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.
MR: !12103
Diffstat (limited to 'app/assets/javascripts/diff_notes')
| -rw-r--r-- | app/assets/javascripts/diff_notes/components/diff_note_avatars.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/app/assets/javascripts/diff_notes/components/diff_note_avatars.js b/app/assets/javascripts/diff_notes/components/diff_note_avatars.js index 517bdb6be09..c37249c060a 100644 --- a/app/assets/javascripts/diff_notes/components/diff_note_avatars.js +++ b/app/assets/javascripts/diff_notes/components/diff_note_avatars.js @@ -139,9 +139,9 @@ const DiffNoteAvatars = Vue.extend({ const notesCount = this.notesCount; $(this.$el).closest('.js-avatar-container') - .toggleClass('js-no-comment-btn', notesCount > 0) + .toggleClass('no-comment-btn', notesCount > 0) .nextUntil('.js-avatar-container') - .toggleClass('js-no-comment-btn', notesCount > 0); + .toggleClass('no-comment-btn', notesCount > 0); }, toggleDiscussionsToggleState() { const $notesHolders = $(this.$el).closest('.code').find('.notes_holder'); |