diff options
| author | Felipe Artur <fcardozo@gitlab.com> | 2017-10-07 07:25:17 +0300 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2017-10-07 07:25:17 +0300 |
| commit | b54203f0ada8f7ad6d24437b6f5f46ebf43f8695 (patch) | |
| tree | b903596b4755da406dfd1349a8b2c59a5f38b9d1 /app/assets/javascripts/diff_notes | |
| parent | b4f9dc48163c065d776d120dd312c689ce79f653 (diff) | |
Commenting on image diffs
Diffstat (limited to 'app/assets/javascripts/diff_notes')
| -rw-r--r-- | app/assets/javascripts/diff_notes/components/jump_to_discussion.js | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/app/assets/javascripts/diff_notes/components/jump_to_discussion.js b/app/assets/javascripts/diff_notes/components/jump_to_discussion.js index 497c23f014f..e77910a83d4 100644 --- a/app/assets/javascripts/diff_notes/components/jump_to_discussion.js +++ b/app/assets/javascripts/diff_notes/components/jump_to_discussion.js @@ -171,7 +171,14 @@ const JumpToDiscussion = Vue.extend({ // When jumping between unresolved discussions on the diffs tab, we show them. $target.closest(".content").show(); - $target = $target.closest("tr.notes_holder"); + const $notesHolder = $target.closest("tr.notes_holder"); + + // Image diff discussions does not use notes_holder + // so we should keep original $target value in those cases + if ($notesHolder.length > 0) { + $target = $notesHolder; + } + $target.show(); // If we are on the diffs tab, we don't scroll to the discussion itself, but to |