diff options
author | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-05-18 18:37:57 +0300 |
---|---|---|
committer | Luke "Jared" Bennett <lbennett@gitlab.com> | 2017-05-31 13:35:05 +0300 |
commit | ab0374f4d6e2bb72ee3040b9b906c2be23519cd7 (patch) | |
tree | d4becd22b82539d752b66295e1010e1e2ba7a149 /app/assets/javascripts/issue_show | |
parent | 07c984d81cd7985d4ab7597cbb21b5f623b438e9 (diff) |
Review changes, improve editable helper spec and add hasUpdated computer to issue_show app
Fix builds by only merge when updated_at_by is presnse
Fix issue_show app.vue hasUpdated reference to state
Fix missing bracket
Diffstat (limited to 'app/assets/javascripts/issue_show')
-rw-r--r-- | app/assets/javascripts/issue_show/components/app.vue | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/app/assets/javascripts/issue_show/components/app.vue b/app/assets/javascripts/issue_show/components/app.vue index aa2b8961f50..638708da100 100644 --- a/app/assets/javascripts/issue_show/components/app.vue +++ b/app/assets/javascripts/issue_show/components/app.vue @@ -71,6 +71,11 @@ export default { titleComponent, editedComponent, }, + computed: { + hasUpdated() { + return !!this.state.updatedAt; + }, + }, created() { const resource = new Service(this.endpoint); const poll = new Poll({ @@ -112,7 +117,7 @@ export default { :description-text="state.descriptionText" :task-status="state.taskStatus" /> <edited-component - v-if="!!state.updatedAt" + v-if="hasUpdated" :updated-at="state.updatedAt" :updated-by-name="state.updatedByName" :updated-by-path="state.updatedByPath" |