Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFatih Acet <acetfatih@gmail.com>2018-06-29 10:22:07 +0300
committerTim Zallmann <tzallmann@gitlab.com>2018-06-29 10:22:07 +0300
commitd690cd9992dbd6a0d231f6c7ea1688ef90f9fc2e (patch)
tree02df5a6d7e6711612180cb155dfad0944a7454ca /app/assets/javascripts/mr_notes/index.js
parent7c6d7accff0a4921d3c863a38382a6114ddb825e (diff)
Prevent fetching diffs and discussions data unnecessarily on MR page
Diffstat (limited to 'app/assets/javascripts/mr_notes/index.js')
-rw-r--r--app/assets/javascripts/mr_notes/index.js10
1 files changed, 5 insertions, 5 deletions
diff --git a/app/assets/javascripts/mr_notes/index.js b/app/assets/javascripts/mr_notes/index.js
index 3c0c9995cc2..8aabb840847 100644
--- a/app/assets/javascripts/mr_notes/index.js
+++ b/app/assets/javascripts/mr_notes/index.js
@@ -45,17 +45,17 @@ export default function initMrNotes() {
this.updateDiscussionTabCounter();
},
},
+ created() {
+ this.setActiveTab(window.mrTabs.getCurrentAction());
+ },
mounted() {
this.notesCountBadge = $('.issuable-details').find('.notes-tab .badge');
- this.setActiveTab(window.mrTabs.getCurrentAction());
-
- window.mrTabs.eventHub.$on('MergeRequestTabChange', tab => {
- this.setActiveTab(tab);
- });
$(document).on('visibilitychange', this.updateDiscussionTabCounter);
+ window.mrTabs.eventHub.$on('MergeRequestTabChange', this.setActiveTab);
},
beforeDestroy() {
$(document).off('visibilitychange', this.updateDiscussionTabCounter);
+ window.mrTabs.eventHub.$off('MergeRequestTabChange', this.setActiveTab);
},
methods: {
...mapActions(['setActiveTab']),