Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Zallmann <tzallmann@gitlab.com>2017-09-22 11:39:47 +0300
committerPhil Hughes <me@iamphill.com>2017-09-22 11:39:47 +0300
commit55f772bb98a67ad346442a2cacb5646f6719b987 (patch)
treefdcda42d5ee9c746b5654a50fa88a0fd1464d3a8 /app/assets/javascripts/notes
parentd103e95513704314a38ab8ae441851524031c4a1 (diff)
Resolve "Better SVG Usage in the Frontend"
Diffstat (limited to 'app/assets/javascripts/notes')
-rw-r--r--app/assets/javascripts/notes/components/issue_note_icons.js37
-rw-r--r--app/assets/javascripts/notes/components/issue_system_note.vue9
2 files changed, 4 insertions, 42 deletions
diff --git a/app/assets/javascripts/notes/components/issue_note_icons.js b/app/assets/javascripts/notes/components/issue_note_icons.js
deleted file mode 100644
index d8e3cb4bc01..00000000000
--- a/app/assets/javascripts/notes/components/issue_note_icons.js
+++ /dev/null
@@ -1,37 +0,0 @@
-import iconArrowCircle from 'icons/_icon_arrow_circle_o_right.svg';
-import iconCheck from 'icons/_icon_check_square_o.svg';
-import iconClock from 'icons/_icon_clock_o.svg';
-import iconCodeFork from 'icons/_icon_code_fork.svg';
-import iconComment from 'icons/_icon_comment_o.svg';
-import iconCommit from 'icons/_icon_commit.svg';
-import iconEdit from 'icons/_icon_edit.svg';
-import iconEye from 'icons/_icon_eye.svg';
-import iconEyeSlash from 'icons/_icon_eye_slash.svg';
-import iconMerge from 'icons/_icon_merge.svg';
-import iconMerged from 'icons/_icon_merged.svg';
-import iconRandom from 'icons/_icon_random.svg';
-import iconClosed from 'icons/_icon_status_closed.svg';
-import iconStatusOpen from 'icons/_icon_status_open.svg';
-import iconStopwatch from 'icons/_icon_stopwatch.svg';
-import iconTags from 'icons/_icon_tags.svg';
-import iconUser from 'icons/_icon_user.svg';
-
-export default {
- icon_arrow_circle_o_right: iconArrowCircle,
- icon_check_square_o: iconCheck,
- icon_clock_o: iconClock,
- icon_code_fork: iconCodeFork,
- icon_comment_o: iconComment,
- icon_commit: iconCommit,
- icon_edit: iconEdit,
- icon_eye: iconEye,
- icon_eye_slash: iconEyeSlash,
- icon_merge: iconMerge,
- icon_merged: iconMerged,
- icon_random: iconRandom,
- icon_status_closed: iconClosed,
- icon_status_open: iconStatusOpen,
- icon_stopwatch: iconStopwatch,
- icon_tags: iconTags,
- icon_user: iconUser,
-};
diff --git a/app/assets/javascripts/notes/components/issue_system_note.vue b/app/assets/javascripts/notes/components/issue_system_note.vue
index 5bb8f871b9d..0cfb6522e77 100644
--- a/app/assets/javascripts/notes/components/issue_system_note.vue
+++ b/app/assets/javascripts/notes/components/issue_system_note.vue
@@ -1,6 +1,5 @@
<script>
import { mapGetters } from 'vuex';
- import iconsMap from './issue_note_icons';
import issueNoteHeader from './issue_note_header.vue';
export default {
@@ -24,9 +23,9 @@
isTargetNote() {
return this.targetNoteHash === this.noteAnchorId;
},
- },
- created() {
- this.svg = iconsMap[this.note.system_note_icon_name];
+ iconHtml() {
+ return gl.utils.spriteIcon(this.note.system_note_icon_name);
+ },
},
};
</script>
@@ -39,7 +38,7 @@
<div class="timeline-entry-inner">
<div
class="timeline-icon"
- v-html="svg">
+ v-html="iconHtml">
</div>
<div class="timeline-content">
<div class="note-header">