Merge branch 'master' into 54282-tooltip-stuck

* master: (24 commits)
  Adds a PHILOSOPHY.md
  Externalize strings from `/app/views/abuse_reports`
  Fix Issuable container element selector for shortcuts handling
  Enable Rubocop on lib/gitlab
  Add user docs for Pages access control
  Added information about syntax highlighting in Web IDE. Fixes gitlab-org/gitlab-ce#53571
  Align issue status label and confidential icon
  Externalize strings from `/app/views/repository_check_mailer`
  Remove instances of `@extend .monospace`
  Resolve "The reply shortcut can add any text of the page to the "comment" text area"
  Upgrade escape_utils to 1.2.1
  Add dedicated runner tags to assets job
  Upgrade gitlab eslint config to latest
  Fix broken karma specs
  Disable conflicting eslint rules
  Prettify all the things
  Upgrade prettier to 1.15.2
  Added a test for open merge request files
  Update CHANGELOG.md for 11.4.7
  Open first 10 merge request files in IDE
  ...

3 files changed, 15 insertions, 72 deletions

diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
index dced839c883..ff6dadeff7d 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/project_feature_setting.vue
@@ -69,16 +69,8 @@ export default {
 </script>
 
 <template>
-  <div
-    :data-for="name"
-    class="project-feature-controls"
-  >
-    <input
-      v-if="name"
-      :name="name"
-      :value="value"
-      type="hidden"
-    />
+  <div :data-for="name" class="project-feature-controls">
+    <input v-if="name" :name="name" :value="value" type="hidden" />
     <project-feature-toggle
       :value="featureEnabled"
       :disabled-input="disabledInput"
@@ -99,11 +91,7 @@ export default {
           {{ optionName }}
         </option>
       </select>
-      <i
-        aria-hidden="true"
-        class="fa fa-chevron-down"
-      >
-      </i>
+      <i aria-hidden="true" class="fa fa-chevron-down"> </i>
     </div>
   </div>
 </template>
diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue
index 898d605463f..92d23772565 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/project_setting_row.vue
@@ -22,30 +22,12 @@ export default {
 
 <template>
   <div class="project-feature-row">
-    <label
-      v-if="label"
-      class="label-bold"
-    >
+    <label v-if="label" class="label-bold">
       {{ label }}
-      <a
-        v-if="helpPath"
-        :href="helpPath"
-        target="_blank"
-      >
-        <i
-          aria-hidden="true"
-          data-hidden="true"
-          class="fa fa-question-circle"
-        >
-        </i>
+      <a v-if="helpPath" :href="helpPath" target="_blank">
+        <i aria-hidden="true" data-hidden="true" class="fa fa-question-circle"> </i>
       </a>
     </label>
-    <span
-      v-if="helpText"
-      class="form-text text-muted"
-    >
-      {{ helpText }}
-    </span>
-    <slot></slot>
+    <span v-if="helpText" class="form-text text-muted"> {{ helpText }} </span> <slot></slot>
   </div>
 </template>
diff --git a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
index c0ec7a5dc94..08c7719dcf2 100644
--- a/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
+++ b/app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
@@ -200,10 +200,7 @@ export default {
 <template>
   <div>
     <div class="project-visibility-setting">
-      <project-setting-row
-        :help-path="visibilityHelpPath"
-        label="Project visibility"
-      >
+      <project-setting-row :help-path="visibilityHelpPath" label="Project visibility">
         <div class="project-feature-controls">
           <div class="select-wrapper">
             <select
@@ -231,36 +228,21 @@ export default {
                 Public
               </option>
             </select>
-            <i
-              aria-hidden="true"
-              data-hidden="true"
-              class="fa fa-chevron-down"
-            >
-            </i>
+            <i aria-hidden="true" data-hidden="true" class="fa fa-chevron-down"> </i>
           </div>
         </div>
         <span class="form-text text-muted">{{ visibilityLevelDescription }}</span>
-        <label
-          v-if="visibilityLevel !== visibilityOptions.PRIVATE"
-          class="request-access"
-        >
+        <label v-if="visibilityLevel !== visibilityOptions.PRIVATE" class="request-access">
           <input
             :value="requestAccessEnabled"
             type="hidden"
             name="project[request_access_enabled]"
           />
-          <input
-            v-model="requestAccessEnabled"
-            type="checkbox"
-          />
-          Allow users to request access
+          <input v-model="requestAccessEnabled" type="checkbox" /> Allow users to request access
         </label>
       </project-setting-row>
     </div>
-    <div
-      :class="{ 'highlight-changes': highlightChangesClass }"
-      class="project-feature-settings"
-    >
+    <div :class="{ 'highlight-changes': highlightChangesClass }" class="project-feature-settings">
       <project-setting-row
         label="Issues"
         help-text="Lightweight issue tracking system for this project"
@@ -271,10 +253,7 @@ export default {
           name="project[project_feature_attributes][issues_access_level]"
         />
       </project-setting-row>
-      <project-setting-row
-        label="Repository"
-        help-text="View and edit files in this project"
-      >
+      <project-setting-row label="Repository" help-text="View and edit files in this project">
         <project-feature-setting
           v-model="repositoryAccessLevel"
           :options="featureAccessLevelOptions"
@@ -293,10 +272,7 @@ export default {
             name="project[project_feature_attributes][merge_requests_access_level]"
           />
         </project-setting-row>
-        <project-setting-row
-          label="Pipelines"
-          help-text="Build, test, and deploy your changes"
-        >
+        <project-setting-row label="Pipelines" help-text="Build, test, and deploy your changes">
           <project-feature-setting
             v-model="buildsAccessLevel"
             :options="repoFeatureAccessLevelOptions"
@@ -329,10 +305,7 @@ export default {
           />
         </project-setting-row>
       </div>
-      <project-setting-row
-        label="Wiki"
-        help-text="Pages for project documentation"
-      >
+      <project-setting-row label="Wiki" help-text="Pages for project documentation">
         <project-feature-setting
           v-model="wikiAccessLevel"
           :options="featureAccessLevelOptions"