diff options
| author | Dennis Tang <dtang@gitlab.com> | 2018-05-08 16:59:47 +0300 |
|---|---|---|
| committer | Dennis Tang <dtang@gitlab.com> | 2018-05-08 16:59:47 +0300 |
| commit | 53e27b8c07a6831d1576d1bbb5b311b3cc5acf9e (patch) | |
| tree | b2e43ec9ff52f9bbb50e6cc3f270f7d7ca93d23a /app/assets/javascripts/projects | |
| parent | 37cfca2cc96073a88e65ed2b4340d9979c48173e (diff) | |
revisions
Diffstat (limited to 'app/assets/javascripts/projects')
4 files changed, 9 insertions, 13 deletions
diff --git a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue index 4ae5fc64a86..42183a04484 100644 --- a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue +++ b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_machine_type_dropdown.vue @@ -139,10 +139,9 @@ export default { v-for="result in results" :key="result.id" > - <a - href="#" - @click.prevent="setMachineType(result.name)" - >{{ result.name }}</a> + <button @click.prevent="setMachineType(result.name)"> + {{ result.name }} + </button> </li> </ul> </div> diff --git a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown.vue b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown.vue index c4547aa4709..7319a254e0f 100644 --- a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown.vue +++ b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_project_id_dropdown.vue @@ -159,10 +159,9 @@ export default { v-for="result in results" :key="result.project_number" > - <a - href="#" - @click.prevent="setProject(result)" - >{{ result.name }}</a> + <button @click.prevent="setProject(result)"> + {{ result.name }} + </button> </li> </ul> </div> diff --git a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown.vue b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown.vue index 103d49fab4c..5bb45e8e3b2 100644 --- a/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown.vue +++ b/app/assets/javascripts/projects/gke_cluster_dropdowns/components/gke_zone_dropdown.vue @@ -124,10 +124,9 @@ export default { v-for="result in results" :key="result.id" > - <a - href="#" - @click.prevent="setZone(result.name)" - >{{ result.name }}</a> + <button @click.prevent="setZone(result.name)"> + {{ result.name }} + </button> </li> </ul> </div> diff --git a/app/assets/javascripts/projects/gke_cluster_dropdowns/index.js b/app/assets/javascripts/projects/gke_cluster_dropdowns/index.js index dac2cc38c89..79255e654f2 100644 --- a/app/assets/javascripts/projects/gke_cluster_dropdowns/index.js +++ b/app/assets/javascripts/projects/gke_cluster_dropdowns/index.js @@ -58,7 +58,6 @@ const initializeGapiClient = () => { const el = document.querySelector('.js-gke-cluster-creation'); gapi.client.setToken({ access_token: el.dataset.token }); - delete el.dataset.token; gapi.client .load(CONSTANTS.GCP_API_CLOUD_RESOURCE_MANAGER_ENDPOINT) |