Improve the JS for the `p b` shortcut and fix its CSS

Signed-off-by: Rémy Coutable <remy@rymai.me>

1 files changed, 4 insertions, 3 deletions

diff --git a/app/assets/javascripts/shortcuts.js b/app/assets/javascripts/shortcuts.js
index 09cb914e884..a4a7f3fa944 100644
--- a/app/assets/javascripts/shortcuts.js
+++ b/app/assets/javascripts/shortcuts.js
@@ -58,10 +58,11 @@ import findAndFollowLink from './shortcuts_dashboard_navigation';
 
     Shortcuts.prototype.onTogglePerfBar = function(e) {
       e.preventDefault();
-      if (Cookies.get('perf_bar_enabled') === 'true') {
-        Cookies.remove('perf_bar_enabled', { path: '/' });
+      const performanceBarCookieName = 'perf_bar_enabled';
+      if (Cookies.get(performanceBarCookieName) === 'true') {
+        Cookies.remove(performanceBarCookieName, { path: '/' });
       } else {
-        Cookies.set('perf_bar_enabled', true, { path: '/' });
+        Cookies.set(performanceBarCookieName, true, { path: '/' });
       }
       gl.utils.refreshCurrentPage();
     };