diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-08-30 07:58:48 +0300 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-08-30 07:58:48 +0300 |
commit | 0f72fc86004f143571398e88cdaa0b6d83b6661e (patch) | |
tree | 55c8696c3ca377d484cc124bb957604ef0b18212 /app/assets/stylesheets/framework/mixins.scss | |
parent | 77fd0a0421864b8af04ceb6474f39cf52fc80b46 (diff) | |
parent | 12784559316fc2c3860641bee9c6f8e2bc12c4ba (diff) |
Merge branch 'css-logo-animation' into 'master'
Change logo animation to CSS
## What does this MR do?
Converts the tanuki logo animation from javascript to CSS. You can now animate the tanuki svg logo by adding the CSS Class `animate`to it.
## Are there points in the code the reviewer needs to double check?
Just need to double check for browser compatibility
## Why was this MR needed?
* Using CSS for simple animations is a best practice (Optimizes DOM, uses GPU to do animation rather than CPU)
* Happy DOM :balloon:
## What are the relevant issue numbers?
Closes #20607
## Screenshots (if relevant)
Before DOM
![8BrOJAqT4U](/uploads/705a3c7b53c45d32d435cafecfc958bd/8BrOJAqT4U.gif)
After DOM
![Screen_Shot_2016-08-03_at_10.30.08_PM](/uploads/e82d9b63501def4dc4e67a5659863680/Screen_Shot_2016-08-03_at_10.30.08_PM.png)
Before
![JnEgliIIVO](/uploads/39aaec48fd3e193f20cf455371ea2d13/JnEgliIIVO.gif)
After (Basically the same, hard to tell in my gif though because it was hard to get the timings right on the recording)
![fvLeXxmp3U](/uploads/058cf15fffed4be549af2e963eca4412/fvLeXxmp3U.gif)
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5655
Diffstat (limited to 'app/assets/stylesheets/framework/mixins.scss')
-rw-r--r-- | app/assets/stylesheets/framework/mixins.scss | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/app/assets/stylesheets/framework/mixins.scss b/app/assets/stylesheets/framework/mixins.scss index 9fb3bcb271e..396a37bab6e 100644 --- a/app/assets/stylesheets/framework/mixins.scss +++ b/app/assets/stylesheets/framework/mixins.scss @@ -88,3 +88,8 @@ color: rgba(255, 255, 255, 0.3); background: rgba(255, 255, 255, 0.1); } + +@mixin webkit-prefix($property, $value) { + #{'-webkit-' + $property}: $value; + #{$property}: $value; +} |