diff options
author | Douwe Maan <douwe@selenight.nl> | 2017-06-30 00:19:09 +0300 |
---|---|---|
committer | micael.bergeron <micaelbergeron@gmail.com> | 2017-12-07 17:01:19 +0300 |
commit | e4eba908cd85c3ad7b9861c3edbd3c81623242a0 (patch) | |
tree | 51704b1351f78fcd3de4a59399b10c5c3f64d70d /app/assets | |
parent | 17542a7895f288b8e7bc92836039f4dcbb7c17d2 (diff) |
Allow commenting on individual commits inside an MR
Diffstat (limited to 'app/assets')
-rw-r--r-- | app/assets/javascripts/diff_notes/diff_notes_bundle.js | 3 | ||||
-rw-r--r-- | app/assets/javascripts/diff_notes/services/resolve.js | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/app/assets/javascripts/diff_notes/diff_notes_bundle.js b/app/assets/javascripts/diff_notes/diff_notes_bundle.js index 0863c3406bd..2f22361d6d2 100644 --- a/app/assets/javascripts/diff_notes/diff_notes_bundle.js +++ b/app/assets/javascripts/diff_notes/diff_notes_bundle.js @@ -16,7 +16,8 @@ import './components/diff_note_avatars'; import './components/new_issue_for_discussion'; $(() => { - const projectPath = document.querySelector('.merge-request').dataset.projectPath; + const projectPathHolder = document.querySelector('.merge-request') || document.querySelector('.commit-box') + const projectPath = projectPathHolder.dataset.projectPath; const COMPONENT_SELECTOR = 'resolve-btn, resolve-discussion-btn, jump-to-discussion, comment-and-resolve-btn, new-issue-for-discussion-btn'; window.gl = window.gl || {}; diff --git a/app/assets/javascripts/diff_notes/services/resolve.js b/app/assets/javascripts/diff_notes/services/resolve.js index 6eae54f830b..96fe23640af 100644 --- a/app/assets/javascripts/diff_notes/services/resolve.js +++ b/app/assets/javascripts/diff_notes/services/resolve.js @@ -43,7 +43,7 @@ class ResolveServiceClass { discussion.resolveAllNotes(resolvedBy); } - gl.mrWidget.checkStatus(); + if (gl.mrWidget) gl.mrWidget.checkStatus(); discussion.updateHeadline(data); }) .catch(() => new Flash('An error occurred when trying to resolve a discussion. Please try again.')); |