diff options
author | Phil Hughes <me@iamphill.com> | 2016-10-05 16:58:29 +0300 |
---|---|---|
committer | Phil Hughes <me@iamphill.com> | 2016-10-06 13:00:01 +0300 |
commit | 2f53a8d08f3b1595dfa48c308e408083b89651f4 (patch) | |
tree | 210d058bb75aed5f89e8d8fa66b4edc116de9a8d /app/assets | |
parent | a68f1fdd2975a9e7cab39ab7d40e3eae2cc676db (diff) |
Shows error if response returns an error
Added validation so the user shouldnt be able to submit the form without the title present
Diffstat (limited to 'app/assets')
-rw-r--r-- | app/assets/javascripts/boards/components/board_new_issue.js.es6 | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/app/assets/javascripts/boards/components/board_new_issue.js.es6 b/app/assets/javascripts/boards/components/board_new_issue.js.es6 index 315c16ee242..58cc30b05af 100644 --- a/app/assets/javascripts/boards/components/board_new_issue.js.es6 +++ b/app/assets/javascripts/boards/components/board_new_issue.js.es6 @@ -8,7 +8,8 @@ }, data() { return { - title: '' + title: '', + error: false }; }, watch: { @@ -19,6 +20,10 @@ methods: { submit(e) { e.preventDefault(); + if (this.title.trim() === '') return; + + this.error = false; + const labels = this.list.label ? [this.list.label] : []; const issue = new ListIssue({ title: this.title, @@ -26,9 +31,21 @@ }); this.list.newIssue(issue) - .then(() => { + .then((data) => { + // Need this because our jQuery very kindly disables buttons on ALL form submissions + $(this.$els.submitButton).enable(); + }) + .catch(() => { // Need this because our jQuery very kindly disables buttons on ALL form submissions $(this.$els.submitButton).enable(); + + // Remove issue with no ID + const issue = this.list.findIssue(undefined); + this.list.removeIssue(issue); + + // Show error message + this.error = true; + this.showIssueForm = true; }); this.cancel(); |