Replace define_method with alias_method in Omniauth Controllers

1 files changed, 6 insertions, 8 deletions

diff --git a/app/controllers/ldap/omniauth_callbacks_controller.rb b/app/controllers/ldap/omniauth_callbacks_controller.rb
index e9219274182..fb24edb8602 100644
--- a/app/controllers/ldap/omniauth_callbacks_controller.rb
+++ b/app/controllers/ldap/omniauth_callbacks_controller.rb
@@ -2,23 +2,21 @@ class Ldap::OmniauthCallbacksController < OmniauthCallbacksController
   extend ::Gitlab::Utils::Override
 
   def self.define_providers!
-    if Gitlab::Auth::LDAP::Config.enabled?
-      Gitlab::Auth::LDAP::Config.available_servers.each do |server|
-        define_method server['provider_name'] do
-          ldap
-        end
-      end
+    return unless Gitlab::Auth::LDAP::Config.enabled?
+
+    Gitlab::Auth::LDAP::Config.available_servers.each do |server|
+      alias_method server['provider_name'], :ldap
     end
   end
 
-  define_providers!
-
   # We only find ourselves here
   # if the authentication to LDAP was successful.
   def ldap
     sign_in_user_flow(Gitlab::Auth::LDAP::User)
   end
 
+  define_providers!
+
   override :set_remember_me
   def set_remember_me(user)
     user.remember_me = params[:remember_me] if user.persisted?