diff options
| author | Stan Hu <stanhu@gmail.com> | 2018-12-10 08:23:15 +0300 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2018-12-10 08:56:31 +0300 |
| commit | 384a92b7362ad75801add04292f6ef7938207fc4 (patch) | |
| tree | 4560a7133fb537fff637c9455b34e5a0cccfa99e /app/controllers/projects/compare_controller.rb | |
| parent | 7cb0dd98590e8fdd7483b9f61643a0daa23c2b67 (diff) | |
Check for valid refs in CommitController before doing anything
Before a 404 would be rendered only after a request to Gitaly would
return with an InvalidArgument error. Now we check that the ref have a
valid format before sending it to Gitaly. In both cases, a 404 is
returned to the user, but this change prevents Gitaly from generating
error noise in production.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1425
Diffstat (limited to 'app/controllers/projects/compare_controller.rb')
| -rw-r--r-- | app/controllers/projects/compare_controller.rb | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/app/controllers/projects/compare_controller.rb b/app/controllers/projects/compare_controller.rb index 2917925947f..5586c2fc631 100644 --- a/app/controllers/projects/compare_controller.rb +++ b/app/controllers/projects/compare_controller.rb @@ -65,12 +65,6 @@ class Projects::CompareController < Projects::ApplicationController private - def valid_ref?(ref_name) - return true unless ref_name.present? - - Gitlab::GitRefValidator.validate(ref_name) - end - def validate_refs! valid = [head_ref, start_ref].map { |ref| valid_ref?(ref) } |