diff options
| author | Filipa Lacerda <filipa@gitlab.com> | 2018-07-12 17:58:33 +0300 |
|---|---|---|
| committer | Filipa Lacerda <filipa@gitlab.com> | 2018-07-13 17:00:14 +0300 |
| commit | fc9f90045d930641690f75e9bae25683dc67a24e (patch) | |
| tree | 1ffe6c8139ad0a32e558b5dfca797151672cbd56 /app/controllers/projects/milestones_controller.rb | |
| parent | cfe2121978a235d93d9bacefde37702bfa1f4848 (diff) | |
Escapes milestone title shown in flash message when promoting a milestone
Diffstat (limited to 'app/controllers/projects/milestones_controller.rb')
| -rw-r--r-- | app/controllers/projects/milestones_controller.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/app/controllers/projects/milestones_controller.rb b/app/controllers/projects/milestones_controller.rb index 5e86ec93f34..17571935c1c 100644 --- a/app/controllers/projects/milestones_controller.rb +++ b/app/controllers/projects/milestones_controller.rb @@ -1,4 +1,5 @@ class Projects::MilestonesController < Projects::ApplicationController + include ActionView::Helpers::SanitizeHelper include Gitlab::Utils::StrongMemoize include MilestoneActions @@ -76,8 +77,8 @@ class Projects::MilestonesController < Projects::ApplicationController def promote promoted_milestone = Milestones::PromoteService.new(project, current_user).execute(milestone) - - flash[:notice] = "#{milestone.title} promoted to <a href=\"#{group_milestone_path(project.group, promoted_milestone.iid)}\"><u>group milestone</u></a>.".html_safe + milestone_title = sanitize(milestone.title) + flash[:notice] = "#{milestone_title} promoted to <a href=\"#{group_milestone_path(project.group, promoted_milestone.iid)}\"><u>group milestone</u></a>.".html_safe respond_to do |format| format.html do redirect_to project_milestones_path(project) |