diff options
| author | Jarka Kadlecova <jarka@gitlab.com> | 2017-09-01 15:03:57 +0300 |
|---|---|---|
| committer | Jarka Kadlecova <jarka@gitlab.com> | 2017-09-14 15:50:32 +0300 |
| commit | 994e7d135947ca162c147c5e0992a0190de22808 (patch) | |
| tree | cd9ea4d93269c8597541f8c59e89a83ca2b56d2b /app/controllers/projects/notes_controller.rb | |
| parent | 2b82f907abf2074ac332531d6142893d081f44b9 (diff) | |
Create system notes for MR too, improve doc + clean up code
Diffstat (limited to 'app/controllers/projects/notes_controller.rb')
| -rw-r--r-- | app/controllers/projects/notes_controller.rb | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/app/controllers/projects/notes_controller.rb b/app/controllers/projects/notes_controller.rb index bb0c1869955..ef7d047b1ad 100644 --- a/app/controllers/projects/notes_controller.rb +++ b/app/controllers/projects/notes_controller.rb @@ -75,12 +75,7 @@ class Projects::NotesController < Projects::ApplicationController end def authorize_create_note! - noteable_type = note_params[:noteable_type] - - return unless %w[MergeRequest Issue].include?(noteable_type) - return access_denied! unless can?(current_user, :create_note, project) - - noteable = noteable_type.constantize.find(note_params[:noteable_id]) + return unless noteable.lockable? access_denied! unless can?(current_user, :create_note, noteable) end end |