diff options
author | Rémy Coutable <remy@rymai.me> | 2016-12-08 20:29:25 +0300 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-12-08 20:35:59 +0300 |
commit | d74ad9263048549e4d90e6a22313768109eaf2c4 (patch) | |
tree | d2ea25e6d8c074175e608860f5bc6f4ee69caeb0 /app/controllers/projects/project_members_controller.rb | |
parent | 10d4b20ad18b735e45da492a1af30b3650df705e (diff) |
Use a single query in Projects::ProjectMembersController to fetch members
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'app/controllers/projects/project_members_controller.rb')
-rw-r--r-- | app/controllers/projects/project_members_controller.rb | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/app/controllers/projects/project_members_controller.rb b/app/controllers/projects/project_members_controller.rb index 3fb8bba3cd0..53308948f62 100644 --- a/app/controllers/projects/project_members_controller.rb +++ b/app/controllers/projects/project_members_controller.rb @@ -35,13 +35,12 @@ class Projects::ProjectMembersController < Projects::ApplicationController @group_links = @project.project_group_links.where(group_id: @project.invited_groups.search(params[:search]).select(:id)) end - member_ids = @project_members.pluck(:id) + wheres = ["id IN (#{@project_members.select(:id).to_sql})"] + wheres << "id IN (#{group_members.select(:id).to_sql})" if group_members - if group_members - member_ids += group_members.pluck(:id) - end - - @project_members = Member.where(id: member_ids).order(access_level: :desc).page(params[:page]) + @project_members = Member. + where(wheres.join(' OR ')). + order(access_level: :desc).page(params[:page]) @requesters = AccessRequestsFinder.new(@project).execute(current_user) |