diff options
author | Matija Čupić <matteeyah@gmail.com> | 2018-02-06 19:56:54 +0300 |
---|---|---|
committer | Matija Čupić <matteeyah@gmail.com> | 2018-02-06 19:56:54 +0300 |
commit | efcdc269e03836e78dcc8d460621c948ac02bc24 (patch) | |
tree | a29e5d401d4182bf7823e91e3948d4ad8f3a95be /app/controllers/projects/variables_controller.rb | |
parent | d05cc9c6a6e46ed024a275240be0a5137622e474 (diff) |
Fix static_analysis failure
Diffstat (limited to 'app/controllers/projects/variables_controller.rb')
-rw-r--r-- | app/controllers/projects/variables_controller.rb | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/app/controllers/projects/variables_controller.rb b/app/controllers/projects/variables_controller.rb index 329e1cdfef0..7eb509e2e64 100644 --- a/app/controllers/projects/variables_controller.rb +++ b/app/controllers/projects/variables_controller.rb @@ -12,17 +12,25 @@ class Projects::VariablesController < Projects::ApplicationController def update if @project.update(variables_params) respond_to do |format| - format.json { return render status: :ok, json: { variables: VariableSerializer.new.represent(@project.variables) } } + format.json { return render_variables } end else respond_to do |format| - format.json { render status: :bad_request, json: @project.errors.full_messages } + format.json { render_error } end end end private + def render_variables + render status: :ok, json: { variables: VariableSerializer.new.represent(@project.variables) } + end + + def render_error + render status: :bad_request, json: @project.errors.full_messages + end + def variables_params params.permit(variables_attributes: [*variable_params_attributes]) end |