diff options
| author | Markus Koller <mkoller@gitlab.com> | 2019-09-02 14:12:20 +0300 |
|---|---|---|
| committer | Markus Koller <mkoller@gitlab.com> | 2019-09-10 16:24:28 +0300 |
| commit | 60755fbc406bd25ab526339899f97a2b27aeb272 (patch) | |
| tree | a60f6fa9beb0c4ccdc27c5f7734c14bc34ad2d21 /app/controllers/snippets_controller.rb | |
| parent | 08b0613302ec813c0735e2c0447a3f7683d7ab87 (diff) | |
Optimize queries for snippet listings
- Avoid N+1 queries for authors and comment counts
- Avoid an additional snippet existence query
Diffstat (limited to 'app/controllers/snippets_controller.rb')
| -rw-r--r-- | app/controllers/snippets_controller.rb | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/app/controllers/snippets_controller.rb b/app/controllers/snippets_controller.rb index 869655e9550..c1e05b72b37 100644 --- a/app/controllers/snippets_controller.rb +++ b/app/controllers/snippets_controller.rb @@ -7,6 +7,7 @@ class SnippetsController < ApplicationController include SnippetsActions include RendersBlob include PreviewMarkdown + include Gitlab::NoteableMetadata skip_before_action :verify_authenticity_token, if: -> { action_name == 'show' && js_request? } @@ -32,7 +33,11 @@ class SnippetsController < ApplicationController @user = UserFinder.new(params[:username]).find_by_username! @snippets = SnippetsFinder.new(current_user, author: @user, scope: params[:scope]) - .execute.page(params[:page]) + .execute + .page(params[:page]) + .inc_author + + @noteable_meta_data = noteable_meta_data(@snippets, 'Snippet') render 'index' else |