diff options
| author | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2015-04-10 17:34:57 +0300 |
|---|---|---|
| committer | Dmitriy Zaporozhets <dzaporozhets@gitlab.com> | 2015-04-10 17:34:57 +0300 |
| commit | 24d139ba971cf61a4b7a01031c4c57bcba29b172 (patch) | |
| tree | 45ebed56c7eb371d69fb61ccd538fba5d16629e7 /app/controllers | |
| parent | 256d2ae7001f7f84835a34d2f2e727eefcbe0c72 (diff) | |
| parent | c9a1634f3183be512e4b94c140a83fa467c238ee (diff) | |
Merge branch 'rs-revert-preload-lib' into 'master'
Revert "Preload lib/"
This reverts commit 5511a731bcc05034abacd4ec01ff7d5a2a3b89d3.
The original commit added this because it also enabled threadsafety, a change which was itself later reverted in 66d6c809662980041fce66d182489c025475e7a7, but this got left behind.
I don't fully understand the reasoning behind it so if I'm wrong, please tell me.
My reasoning for reverting it is that it messes with Rails' (and by extension Spring's) class reloading during development. When I was working in `lib/gitlab/markdown` and had to stop and restart the server every time I made a change, I didn't know it at the time, but this was why. That was a huge pain point.
If it's needed for production perhaps we could add a `if Rails.env.production?` clause around it so that it doesn't mess with development.
See merge request !1758
Diffstat (limited to 'app/controllers')
0 files changed, 0 insertions, 0 deletions