Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames Lopez <james@jameslopez.es>2017-06-22 09:55:07 +0300
committerJames Lopez <james@jameslopez.es>2017-06-23 12:41:42 +0300
commit785cbb79e255c8369ca5eb916207304f39d188ad (patch)
treeabd792d12be1f35d868db591793311eb32d92370 /app/controllers
parent0c8e7f49d1ef32ed5ea1bdd7e26dd5e169bad359 (diff)
refactor emails service
Diffstat (limited to 'app/controllers')
-rw-r--r--app/controllers/admin/users_controller.rb8
-rw-r--r--app/controllers/profiles/emails_controller.rb4
2 files changed, 3 insertions, 9 deletions
diff --git a/app/controllers/admin/users_controller.rb b/app/controllers/admin/users_controller.rb
index 4c43d12d317..065ebf81793 100644
--- a/app/controllers/admin/users_controller.rb
+++ b/app/controllers/admin/users_controller.rb
@@ -136,7 +136,7 @@ class Admin::UsersController < Admin::ApplicationController
# restore username to keep form action url.
user.username = params[:id]
format.html { render "edit" }
- format.json { render json: result[:message], status: result[:status] }
+ format.json { render json: [result[:message]], status: result[:status] }
end
end
end
@@ -152,11 +152,7 @@ class Admin::UsersController < Admin::ApplicationController
def remove_email
email = user.emails.find(params[:email_id])
- Emails::DestroyService.new(current_user, self, email: email.email).execute
-
- result = Users::UpdateService.new(current_user, @user).execute do |user|
- user.update_secondary_emails!
- end
+ Emails::DestroyService.new(current_user, user, email: email.email).execute
respond_to do |format|
if result[:status] == :success
diff --git a/app/controllers/profiles/emails_controller.rb b/app/controllers/profiles/emails_controller.rb
index 40b43278439..5c7a5fa9a64 100644
--- a/app/controllers/profiles/emails_controller.rb
+++ b/app/controllers/profiles/emails_controller.rb
@@ -18,9 +18,7 @@ class Profiles::EmailsController < Profiles::ApplicationController
def destroy
@email = current_user.emails.find(params[:id])
- Emails::DestroyService.new(self, self, email: @email.email).execute
-
- Users::UpdateService.new(current_user, current_user).execute { |user| user.update_secondary_emails! }
+ Emails::DestroyService.new(current_user, current_user, email: @email.email).execute
respond_to do |format|
format.html { redirect_to profile_emails_url, status: 302 }