diff options
| author | Jacob Schatz <jschatz@gitlab.com> | 2016-08-03 07:15:39 +0300 |
|---|---|---|
| committer | Jacob Schatz <jschatz@gitlab.com> | 2016-08-03 07:15:39 +0300 |
| commit | 195b20e1b9ff08437c5a436dc14f04e7f1bee807 (patch) | |
| tree | c72759b1b88720c7d3f54fcad14a5b76793fa519 /app/controllers | |
| parent | 3552900733aa86035d8cc50a1180727cba5915bb (diff) | |
| parent | 6e87ce282db9f5264f77ae2238c1fff23beece1a (diff) | |
Merge branch 'discussion-reply-button-performance' into 'master'
Remove delay when hitting Reply... button on page with a lot of comments
Every time the "Reply..." button was hit, a new `GLForm` was instantiated (which is fine), which would then call `GitLab.GfmAutoComplete.setup()` without specifying which textarea we needed autocompletion on, which resulted in `GitLab.GfmAutoComplete.setup` iterating through every single textarea on the page. On a page with a lot of comments, where each comment would have its own textarea that will be used to edit the comment, this would take a long time and cause the whole page to hang for 2 seconds when a "Reply..." button was clicked.
See merge request !5602
Diffstat (limited to 'app/controllers')
0 files changed, 0 insertions, 0 deletions