diff options
author | Shinya Maeda <gitlab.shinyamaeda@gmail.com> | 2017-03-30 12:59:45 +0300 |
---|---|---|
committer | Shinya Maeda <gitlab.shinyamaeda@gmail.com> | 2017-05-02 20:11:51 +0300 |
commit | 0a36bfa994582b690a7935fed4c15d42b22bd0ed (patch) | |
tree | a3cc8fedbed53f6bfc5e30cfafc5df59100a73e3 /app/finders | |
parent | 4bd0d8e433cdffba9e28a24657104eb2b0b0e761 (diff) |
Use HasStatus::AVAILABLE_STATUSES instead of hard coding
Diffstat (limited to 'app/finders')
-rw-r--r-- | app/finders/pipelines_finder.rb | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/app/finders/pipelines_finder.rb b/app/finders/pipelines_finder.rb index 7935878d1d5..c6666802b7f 100644 --- a/app/finders/pipelines_finder.rb +++ b/app/finders/pipelines_finder.rb @@ -54,22 +54,9 @@ class PipelinesFinder end def by_status(items) - case params[:status] - when 'running' - items.running - when 'pending' - items.pending - when 'success' - items.success - when 'failed' - items.failed - when 'canceled' - items.canceled - when 'skipped' - items.skipped - else - items - end + return items unless HasStatus::AVAILABLE_STATUSES.include?(params[:status]) + + items.where(status: params[:status]) end def by_ref(items) |