diff options
author | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-10 23:45:05 +0300 |
---|---|---|
committer | Annabel Dunstone Gray <annabel.dunstone@gmail.com> | 2016-10-10 23:45:05 +0300 |
commit | 5196f6028cf57dc02c25f95edbb933e3f403b016 (patch) | |
tree | f2a8d2ed17736c6e4e5b6ad70eac2c97fcc527d6 /app/helpers/button_helper.rb | |
parent | a5cd9c9a596c4160bbdc7645f57266655488386c (diff) | |
parent | df4c4833fc68f10edbdf0873ea3238bba53a7a80 (diff) |
Merge branch 'remove-redundant-mixins' into 'master'
Remove redundant mixins
## What does this MR do?
Removes the following redundant mixins
```
@mixin box-shadow($shadow) {
box-shadow: $shadow;
}
@mixin border-radius($radius) {
border-radius: $radius;
}
```
## Are there points in the code the reviewer needs to double check?
Just need to make sure the refactor didn't break anything. Last time I did something like this, we faced an edge case where values `.5` would pass correctly in mixins but not when passed directly to the property.
## Why was this MR needed?
* Reduces redundant code which leads to happier developers :smile:
## Screenshots (if relevant)
None
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Closes #22012
See merge request !6287
Diffstat (limited to 'app/helpers/button_helper.rb')
0 files changed, 0 insertions, 0 deletions