Changes after review

1 files changed, 4 insertions, 6 deletions

diff --git a/app/helpers/environment_helper.rb b/app/helpers/environment_helper.rb
index 96d6f64eb8e..ff8550439d0 100644
--- a/app/helpers/environment_helper.rb
+++ b/app/helpers/environment_helper.rb
@@ -14,14 +14,12 @@ module EnvironmentHelper
     end
   end
 
-  def deployment_link(deployment, text)
+  def deployment_link(deployment, text: nil)
     return unless deployment
 
-    if text
-      link_to text, [deployment.project.namespace.becomes(Namespace), deployment.project, deployment.deployable]
-    else
-      link_to "##{deployment.iid}", [deployment.project.namespace.becomes(Namespace), deployment.project, deployment.deployable]
-    end
+    link_label = text ? text : "##{deployment.iid}"
+
+    link_to link_label, [deployment.project.namespace.becomes(Namespace), deployment.project, deployment.deployable]
   end
 
   def last_deployment_link_for_environment_build(project, build)