diff options
| author | Gabriel Mazetto <brodock@gmail.com> | 2018-11-14 08:07:35 +0300 |
|---|---|---|
| committer | Gabriel Mazetto <brodock@gmail.com> | 2018-12-10 23:34:33 +0300 |
| commit | 4f5abe43279e96efde5f8cac66cbff30d8a95f28 (patch) | |
| tree | 931664a9662da2de4ce46781d2715f6426afc120 /app/helpers/events_helper.rb | |
| parent | 1297a1bd7dcccaa4e233925c8467c2bbe41a4bf2 (diff) | |
Reduce N+1 from Activity Dashboard and Banzai
There is a combination of few strategies implemented here:
1. Few relations were eager loaded
2. Changed few polymorphic routes to specific ones so we don't have to
use `#becomes(Namespace)` which doesn't preserve association cache
Diffstat (limited to 'app/helpers/events_helper.rb')
| -rw-r--r-- | app/helpers/events_helper.rb | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb index 3ce2398f1de..1371e9993b4 100644 --- a/app/helpers/events_helper.rb +++ b/app/helpers/events_helper.rb @@ -161,6 +161,10 @@ module EventsHelper project_commit_url(event.project, event.note_target, anchor: dom_id(event.target)) elsif event.project_snippet_note? project_snippet_url(event.project, event.note_target, anchor: dom_id(event.target)) + elsif event.issue_note? + project_issue_url(event.project, id: event.note_target, anchor: dom_id(event.target)) + elsif event.merge_request_note? + project_merge_request_url(event.project, id: event.note_target, anchor: dom_id(event.target)) else polymorphic_url([event.project.namespace.becomes(Namespace), event.project, event.note_target], |