diff options
| author | Greg Stark <stark@gitlab.com> | 2017-12-11 19:40:03 +0300 |
|---|---|---|
| committer | Greg Stark <stark@gitlab.com> | 2017-12-12 17:01:53 +0300 |
| commit | e8ab4d92b410f46ca87d31a1376acd94f90d1dd9 (patch) | |
| tree | d55dac3b8663232bfe1c2ff893147cd0b6cd44bf /app/models/concerns/cache_markdown_field.rb | |
| parent | be8ca260dadae948d09a87664baed8c85d133434 (diff) | |
Treat empty markdown and html strings as valid cached text, not missing cache that needs to be updated
Diffstat (limited to 'app/models/concerns/cache_markdown_field.rb')
| -rw-r--r-- | app/models/concerns/cache_markdown_field.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/app/models/concerns/cache_markdown_field.rb b/app/models/concerns/cache_markdown_field.rb index 98776eab424..90ad644ce34 100644 --- a/app/models/concerns/cache_markdown_field.rb +++ b/app/models/concerns/cache_markdown_field.rb @@ -85,8 +85,7 @@ module CacheMarkdownField def cached_html_up_to_date?(markdown_field) html_field = cached_markdown_fields.html_field(markdown_field) - cached = cached_html_for(markdown_field).present? && __send__(markdown_field).present? # rubocop:disable GitlabSecurity/PublicSend - return false unless cached + return false if cached_html_for(markdown_field).nil? && !__send__(markdown_field).nil? # rubocop:disable GitlabSecurity/PublicSend markdown_changed = attribute_changed?(markdown_field) || false html_changed = attribute_changed?(html_field) || false |