diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 12:36:54 +0300 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-09-20 13:35:25 +0300 |
| commit | 8957293d9bd0d711db3af26182205c2fe4125194 (patch) | |
| tree | dcdd25393e2d6248971fddbd6c9eac30fe27ff6e /app/models/cycle_analytics.rb | |
| parent | fa890604aaf15b9e4f0199e6a4cff24c29955a37 (diff) | |
Implement review comments from @yorickpeterse
1. Change multiple updates to a single `update_all`
2. Use cascading deletes
3. Extract an average function for the database median.
4. Move database median to `lib/gitlab/database`
5. Use `delete_all` instead of `destroy_all`
6. Minor refactoring
Diffstat (limited to 'app/models/cycle_analytics.rb')
| -rw-r--r-- | app/models/cycle_analytics.rb | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/app/models/cycle_analytics.rb b/app/models/cycle_analytics.rb index ef3f1bbcab5..d5f1c754dad 100644 --- a/app/models/cycle_analytics.rb +++ b/app/models/cycle_analytics.rb @@ -1,5 +1,5 @@ class CycleAnalytics - include DatabaseMedian + include Gitlab::Database::Median def initialize(project, from:) @project = project @@ -122,7 +122,9 @@ class CycleAnalytics case ActiveRecord::Base.connection.adapter_name when 'PostgreSQL' - result.first['median'].to_f + result = result.first.presence + median = result['median'] if result + median.to_f if median when 'Mysql2' result.to_a.flatten.first end |